Skip to content

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Oct 9, 2025

Why is this change needed?

Remove the top-up card on predefined data and remove the connected fields and views on this

How was the change implemented?

Removed from manifest, models and views

New unit tests

Unit tests executed by the author

How to test manually

Related links


Note

Remove Top-up Card identification support across the module (data, model, views, tests, i18n, and docs) and update manifest summary.

  • Removal: Top-up Card identification
    • Delete data/top_up_card.xml and drop models/reg_id.py (removes card_uid field and 10-char UID constraint) and its import in models/__init__.py.
    • Strip card_uid from registrant views in views/registrant_view.xml.
    • Remove unit test tests/test_top_up_id.py and its tests/__init__.py reference.
    • Purge related i18n strings from i18n/*.po and *.pot.
    • Update docs (README.rst, readme/DESCRIPTION.md, static/description/index.html) to remove Top-up Card references.
    • Manifest: remove Top-up Card data file from data and shorten summary.

Written by Cursor Bugbot for commit a9afae4. This will update automatically on new commits. Configure here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (cf9a829) to head (a9afae4).

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #855      +/-   ##
==========================================
- Coverage   81.25%   81.25%   -0.01%     
==========================================
  Files         818      815       -3     
  Lines       24985    24957      -28     
  Branches     2917     2914       -3     
==========================================
- Hits        20302    20278      -24     
+ Misses       3949     3944       -5     
- Partials      734      735       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review November 27, 2025 02:50
@sonarqubecloud
Copy link

@gonzalesedwin1123 gonzalesedwin1123 merged commit aef0602 into 17.0 Nov 27, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants